Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioning of XML PR #208

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Versioning of XML PR #208

merged 2 commits into from
Dec 5, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd commented Dec 5, 2022 •
edited
Loading

Issues addressed by this PR

Fixes #209

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 5, 2022

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on XML_Toolkit

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Dec 5, 2022

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on XML_Toolkit

@FraserGreenroyd FraserGreenroyd mentioned this pull request Dec 5, 2022
Closed
@FraserGreenroyd FraserGreenroyd mentioned this pull request Dec 5, 2022
Merged
@bhombot-ci
Copy link

bhombot-ci bot commented Dec 5, 2022

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on XML_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 5, 2022

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on XML_Toolkit

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 5, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check core

@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review December 5, 2022 18:03
@FraserGreenroyd FraserGreenroyd self-assigned this Dec 5, 2022
@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Dec 5, 2022
jamesramsden-bh
jamesramsden-bh approved these changes Dec 5, 2022
View reviewed changes
Copy link

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demonstrated by Fraser in a code review with a FromJson component to force a versioning upgrade now upgrades correctly.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 5, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

CKBoulter
CKBoulter approved these changes Dec 5, 2022
View reviewed changes
Copy link

@CKBoulter CKBoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review showed by Fraser to force a versioning upgrade which now upgrades correctly without issues.

@FraserGreenroyd FraserGreenroyd merged commit 3744144 into main Dec 5, 2022
@FraserGreenroyd FraserGreenroyd deleted the RenameBluebeamDepth branch December 5, 2022 18:13
@FraserGreenroyd FraserGreenroyd mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CKBoulter CKBoulter CKBoulter approved these changes

@jamesramsden-bh jamesramsden-bh jamesramsden-bh approved these changes

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Versioning of dictionarys
3 participants
@FraserGreenroyd @jamesramsden-bh @CKBoulter